Thread (3 messages) 3 messages, 3 authors, 2011-11-01

Re: [md PATCH 1/1] add display of hours remaining to finish resync

From: NeilBrown <hidden>
Date: 2011-11-01 23:32:46

On Tue, 01 Nov 2011 17:53:47 -0400 Krzysztof Adamski [off-list ref] wrote:
This is my first patch, so please be gentle.
Always.
This patch adds the display of the number of hours till the completion
of resync of an array in the /proc/mdstat display.

Example: [>....................]  resync =  3.3% (98633240/2928311808)
finish=1026.1min (17h) speed=45957K/sec
Thanks.
While I can see the attraction of this I am always cautious of making
unnecessary changes to /proc/mdstat.
It is very likely that people have ad-hoc scripts and programs which parse
the output and do something with it.
While I think it is unlikely that the change you have suggested will break
any such script, I cannot be at all sure that it won't break one.
And I really don't like breaking things.

There certainly is value in having a way to see at a glance the over-all
status of md.  Currently that is
    watch cat /proc/mdstat
(I run that whenever I am testing).
However if we want to improve it, I think it would be best to write a
separate program that gathers data from there /proc/mdstat
and/or /sys/block/md*/md/  and presents nicely-formatted output.

mdtop??

Thanks,
NeilBrown
quoted hunk ↗ jump to hunk
Signed-off-by: Krzysztof Adamski <redacted>

# diff -Naru drivers/md/md.c-orig  drivers/md/md.c
--- drivers/md/md.c-orig        2011-10-25 01:11:12.000000000 -0400
+++ drivers/md/md.c     2011-11-01 17:37:35.000000000 -0400
@@ -6351,8 +6351,8 @@
        rt *= dt;
        rt >>= 5;
 
-       seq_printf(seq, " finish=%lu.%lumin", (unsigned long)rt / 60,
-                  ((unsigned long)rt % 60)/6);
+       seq_printf(seq, " finish=%lu.%lumin (%luh)", (unsigned long)rt /
60,
+                  ((unsigned long)rt % 60)/6, (unsigned long)rt / 60 /
60);
 
        seq_printf(seq, " speed=%ldK/sec", db/2/dt);
 }



--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
  

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help