Thread (24 messages) 24 messages, 3 authors, 2011-11-02
STALE5343d

[PATCH 05/19] remove_devices(): readlink returns -1 on error

From: <hidden>
Date: 2011-11-01 15:09:21
Subsystem: the rest · Maintainer: Linus Torvalds

From: Jes Sorensen <redacted>

Signed-off-by: Jes Sorensen <redacted>
---
 Manage.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Manage.c b/Manage.c
index 2d8c916..613a549 100644
--- a/Manage.c
+++ b/Manage.c
@@ -156,7 +156,7 @@ static void remove_devices(int devnum, char *path)
 				sprintf(pe, "%d", part);
 		}
 		n = readlink(path2, link, sizeof(link));
-		if (n && (int)strlen(base) == n &&
+		if (n > 0 && (int)strlen(base) == n &&
 		    strncmp(link, base, n) == 0)
 			unlink(path2);
 	}
-- 
1.7.6.4
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help