Re: [PATCH 1/2] imsm:FIX: change arrays reshape order
flat view
From: NeilBrown <hidden>
Date: 2011-01-31 09:18:00
On Mon, 31 Jan 2011 09:59:22 +0100 Adam Kwolek [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Reshape is started from second array, so it causes imsm incompatibility and problems during second array start. Reshape should be started in arrays metadata order. Signed-off-by: Adam Kwolek <redacted> --- super-intel.c | 9 ++++++++- 1 files changed, 8 insertions(+), 1 deletions(-)diff --git a/super-intel.c b/super-intel.c index f578057..8484df6 100644 --- a/super-intel.c +++ b/super-intel.c@@ -5848,6 +5848,7 @@ static int apply_reshape_container_disks_update(struct imsm_update_reshape *u, int devices_to_reshape = 1; struct imsm_super *mpb = super->anchor; int ret_val = 0; + unsigned int dev_id; dprintf("imsm: imsm_process_update() for update_reshape\n");@@ -5877,11 +5878,17 @@ static int apply_reshape_container_disks_update(struct imsm_update_reshape *u, " mpb->num_raid_devs = %i\n", mpb->num_raid_devs); /* manage changes in volume */ - for (id = super->devlist ; id; id = id->next) { + for (dev_id = 0; dev_id < mpb->num_raid_devs; dev_id++) { void **sp = *space_list; struct imsm_dev *newdev; struct imsm_map *newmap, *oldmap; + for (id = super->devlist ; id; id = id->next) { + if (id->index == dev_id) + break; + }
Could you replace that loop with a call to get_imsm_dev please? Otherwise, this look good. Thanks, NeilBrown
quoted hunk ↗ jump to hunk
+ if (id == NULL) + break; if (!sp) continue; *space_list = *sp;