Re: [PATCH] block: make sure FSEQ_DATA request has the same rq_disk as the original

Hi Tejun,

On 09/03/2010 08:42 PM +0900, Tejun Heo wrote:

Hello,

On 09/03/2010 12:28 PM, Kiyoshi Ueda wrote:

quoted

Thank you for pointing it.
Yes, the interface should also set rq->q.

About the naming of the interface, blk_set_<something> sounds
reasonable to me.
But does blk_set_rq_q() take request and queue as arguments?
Then, I'm afraid we can't find bdev for bio from given queue.

Oh, right.  Maybe blk_set_rq_bdev() then?

Yeah, although struct request doesn't have the member 'bdev',
blk_set_rq_bdev() may be better from the view of the arguments.

Thanks,
Kiyoshi Ueda