Thread (6 messages) 6 messages, 2 authors, 2010-08-12
STALE5807d

[mdadm PATCH 1/2] Incremental: return success in 'container not enough' case

From: Dan Williams <hidden>
Date: 2010-08-10 16:46:43
Subsystem: the rest · Maintainer: Linus Torvalds

Commit 97b4d0e9 "Incremental: honor an 'enough' flag from external
handlers" introduced a regression in that it changed the error return
code for successful invocations.

Signed-off-by: Dan Williams <redacted>
---
 Incremental.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Incremental.c b/Incremental.c
index a8a072d..e4b6196 100644
--- a/Incremental.c
+++ b/Incremental.c
@@ -264,7 +264,7 @@ int Incremental(char *devname, int verbose, int runstop,
 		else {
 			if (verbose)
 				fprintf(stderr, Name ": not enough devices to start the container\n");
-			return 1;
+			return 0;
 		}
 
 		/* This is a pre-built container array, so we do something
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help