Re: [PATCH 1/4] block: make __blk_rq_prep_clone() copy most command flags

From
Mike Snitzer <hidden>
Date
2010-08-27 17:57:11
Also in
linux-fsdevel, lkml
Reply to
Tejun Heo, 2010-08-27
On Fri, Aug 27 2010 at  1:10pm -0400,
Tejun Heo [off-list ref] wrote:
Currently __blk_rq_prep_clone() copies only REQ_WRITE and REQ_DISCARD.
There's no reason to omit other command flags and REQ_FUA needs to be
copied to implement FUA support in request-based dm.

REQ_COMMON_MASK which specifies flags to be copied from bio to request
already identifies all the command flags.  Define REQ_CLONE_MASK to be
the same as REQ_COMMON_MASK for clarity and make __blk_rq_prep_clone()
copy all flags in the mask.

Signed-off-by: Tejun Heo <tj@kernel.org>
Looks great.

Acked-by: Mike Snitzer <redacted>
Thread (7 messages) 7 messages, 2 authors, last reply 2010-08-27
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help