Re: [patch 1/5] mm: add nofail variants of kmalloc kcalloc and kzalloc

On 2010-08-24 15:29, Peter Zijlstra wrote:

On Tue, 2010-08-24 at 03:50 -0700, David Rientjes wrote:

quoted

These were added as helper functions for documentation and auditability.
No future callers should be added.

git grep GFP_NOFAIL isn't auditable enough?

might as well declare these functions depricated if you really want to
do this.

Agree, adding a helper function would seem to be going in the reverse
direction imho. Nobody will read that comment on top of the function.

Should be possible to warn at build time for anyone using __GFP_NOFAIL
without wrapping it in a function.

-- 
Jens Axboe