Thread (1 message) 1 message, 1 author, 2010-08-12

Re: [PATCH v2] SCSI: fix bio.bi_rw handling

From: Jeff Moyer <hidden>
Date: 2010-08-12 13:30:57
Also in: linux-scsi, lkml

Jiri Slaby [off-list ref] writes:
Return of the bi_rw tests is no longer bool after commit 74450be1. So
testing against constants doesn't make sense anymore. Fix this bug in
osd_req_read by removing "== 1" in test.

This is not a problem now, where REQ_WRITE is 1, but this can change
in the future and we don't want to rely on that.

Signed-off-by: Jiri Slaby <redacted>
Cc: "James E.J. Bottomley" <redacted>
Cc: Christoph Hellwig <hch@lst.de>
Reviewed-by: Jeff Moyer <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help