J Jeff Moyer #
Message details and related content
Jiri Slaby [off-list ref] writes:
Commit 74450be1 (block: unify flags for struct bio and struct request) added direct test of flags in the & form: const bool do_sync = (bio->bi_rw & REQ_SYNC); But this doesn't fit into bool with my compiler (gcc 4.5). So change the type to ulong to avoid the bug.
At first I wondered why you didn't use the !! trick, but after looking at the code, I see that the result is |'d into bi_rw. Looks good. Sounds like it might have been a real bear to track down. Reviewed-by: Jeff Moyer <redacted>