Thread (5 messages) 5 messages, 2 authors, 2010-08-01

Re: [PATCH]md:dm.c Fix warning: statement with no effect

From: Alasdair G Kergon <agk@redhat.com>
Date: 2010-07-31 19:08:15
Also in: dm-devel, lkml

On Sat, Jul 31, 2010 at 12:05:04PM -0700, Justin P. Mattock wrote:
haven't heard any feedback on this any ideas?
quoted
Ive noticed that having CONFIG_BLK_DEV_INTEGRITY=n I get warning messages generated by GCC(below)
   CC      drivers/md/dm.o
drivers/md/dm.c: In function 'split_bvec':
drivers/md/dm.c:1117:3: warning: statement with no effect
drivers/md/dm.c: In function 'clone_bio':
drivers/md/dm.c:1145:3: warning: statement with no effect
I'd suggest hiding it inside the .h files and not trying to scatter #ifdefs 
throughout the code.

Alasdair
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help