Re: Auto Rebuild on hot-plug

On 03/29/2010 02:36 PM, John Robinson wrote:

On 29/03/2010 19:10, Doug Ledford wrote:
[...]

quoted

All of the above actions are related to domains that are degraded.  But
what to do if the array isn't degraded?  We could add the device as a
spare, but if the array isn't degraded, adding a new hot spare doesn't
really *do* anything.  No rebuild will start, nothing immediate happens,
it just goes in and sits there.  And now that we have all these fancy
grow options, it's not entirely clear that a user would want that
anyway.  So, I would argue that if the array isn't degraded, then there
is no sense of emergency in our actions, and there exists multiple
options for what to do with the device, some include being a hot spare
while others include using the device to grow the array, and the
possibilities and answers to what to do here are not at all clear.  Even
if the user had previously configured us to treat the device as a spare,
they may change their mind and want to grow things.  Given that there's
no immediate need to do anything as there aren't any degraded arrays, I
say let the user do whatever they want and don't try to do anything
automatically as it seems likely to me that the user's wants in this
area are likely to change from time to time based on circumstances and
having them update the config file prior to inserting the device is more
klunky than just telling them to do whatever they want themselves after
inserting the device.

[...]

Yes, but do create the partition(s), boot sector, etc and set up the
spare(s).

Really, we should never have to do this in the situation I listed: aka
no degraded arrays exist.  This implies that if you had a raid1 /boot
array, that it's still intact.  So partitioning and setting up boot
loaders doesn't make sense as the new disk isn't going in to replace
anything.  You *might* want to add it to the raid1 /boot, but we don't
know that so doing things automatically doesn't make sense.

The user installed the system with anaconda or whatever, and
may not know the incantations to partition his new disc or install a
boot loader, so if he's managed to configure a mdadm.conf which says the
spare slots in his RAID chassis should belong to mdadm, prepare them for
him. Then all he needs to do is issue whatever grow command.

I think the exception to this is /boot on RAID-1, where I would prefer
to be able to have the system automatically add the new partition as an
active mirror instead of a hot spare, in case this new drive is what we
have to boot off next time.

Again, I'm drawing a distinction here between a degraded array and a
non-degraded array.  If the current array isn't degraded, then we won't
be booting off the new drive next time unless the user goes into the
BIOS and sets the new drive as the active boot device.  And if the user
is going to do that, then they ought to be able to setup their new boot
mirror member themselves.

I suppose there might be circumstances where you want to do something
else, like Netgear do on their ReadyNAS, but while it might be nice to
be able to configure that sort of automatic growing and reshaping, it
doesn't belong in the default config.

Cheers,

John.

-- 
Doug Ledford [off-list ref]
              GPG KeyID: CFBFF194
	      http://people.redhat.com/dledford

Infiniband specific RPMs available at
	      http://people.redhat.com/dledford/Infiniband