On Thu, 28 Jan 2010 17:31:57 +0100
Andre Noll [off-list ref] wrote:

On 16:48, Artur Wojcik wrote:

quoted

mdadm should not wait indefinitely when it trys to reset
superblock on device which is busy (cannot be opened).

Thanks.

quoted

Signed-off-by: Artur Wojcik <redacted>
---
 Kill.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Kill.c b/Kill.c
index 63442a6..a65b865 100644
--- a/Kill.c
+++ b/Kill.c

@@ -46,7 +46,7 @@ int Kill(char *dev, struct supertype *st, int force, int quiet, int noexcl)
 			fprintf(stderr, Name ": Couldn't open %s for write - not zeroing\n",
 				dev);
 		close(fd);
-		return 1;
+		return 2;
 	}
 	if (st == NULL)
 		st = guess_super(fd);

Jup.

	Acked-by: Andre Noll [off-list ref]

BTW: Mind to kill the close(fd) as well (as fd is negative) while
we're at it? A comment that explains the meaning of the return value
would also be nice.

Done and done.

I really don't know why the loop in mdadm.c cared about the different
possible return values - I cannot see any justification for it.

Thanks,
NeilBrown