Thread (2 messages) 2 messages, 2 authors, 2009-01-12

Re: dmaengine: fix dependency chaining

flat view

From: Dan Williams <hidden>
Date: 2009-01-12 22:12:42

On Mon, Jan 12, 2009 at 2:22 PM, Yuri Tikhonov [off-list ref] wrote:
In dmaengine we track the dependencies between the descriptors
using the 'next' pointers of the structure. These pointers are
set to NULL as soon as the corresponding descriptor has been
submitted to the channel (in dma_run_dependencies()).

But, the first 'next' in chain is still remaining set, regardless
the fact, that tx->next has been already submitted. This may lead to
multiple submissions of the same descriptor. This patch fixes this.

Actually, some previous implementation of the xxx_run_dependencies()
function already had this fix in place. The fdb..0eaf3 commit, beside the
correct things, broke this.

Signed-off-by: Yuri Tikhonov <redacted>
Applied, thanks Yuri.

--
Dan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help