Re: typo in raid[456] kernel code/no change based on type?
From: Andre Noll <hidden>
Date: 2008-11-14 18:07:53
Also in:
lkml
Attachments
- signature.asc [application/pgp-signature] 189 bytes
From: Andre Noll <hidden>
Date: 2008-11-14 18:07:53
Also in:
lkml
On 08:05, Justin Piszcz wrote:
[ patch ] # patch -p1 < /home/jpiszcz/patch patching file drivers/md/raid5.c Hunk #1 succeeded at 4302 (offset -41 lines). Ok, fixed some of them but not all:
Sure. The main part of the raid 4/5/6 code is in the single file raid5.c which frequently calls all its supported raid levels "raid5". The patch I've posted only cleans up one function in that file.
Here is the current output that still contains 'raid5': $ dmesg | grep -i raid5 [ 19.881548] md: raid5 personality registered for level 5 [ 21.408354] raid5: device sdl1 operational as raid disk 8 [ 21.410583] raid5: device sdk1 operational as raid disk 1 [ 21.412789] raid5: device sdj1 operational as raid disk 5 [ 21.414994] raid5: device sdi1 operational as raid disk 9 [ 21.417217] raid5: device sdh1 operational as raid disk 7 [ 21.419420] raid5: device sdg1 operational as raid disk 6 [ 21.421622] raid5: device sdf1 operational as raid disk 3 [ 21.423810] raid5: device sde1 operational as raid disk 2 [ 21.425970] raid5: device sdd1 operational as raid disk 0 [ 21.428090] raid5: device sdc1 operational as raid disk 4 [ 21.430884] raid5: allocated 10568kB for md3 [ 21.433023] raid5: raid level 6 set md3 active with 10 out of 10 devices, algorithm 2
Of course these can also be fixed easily. But let's first see whether Neil wants to take such trivial stuff ATM. Andre -- The only person who always got his work done by Friday was Robinson Crusoe