On Tuesday January 23, akpm@osdl.org wrote:
On Tue, 23 Jan 2007 11:26:52 +1100
NeilBrown [off-list ref] wrote:
quoted
+ for (j = 0; j < vcnt ; j++)
+ memcpy(page_address(sbio->bi_io_vec[j].bv_page),
+ page_address(pbio->bi_io_vec[j].bv_page),
+ PAGE_SIZE);
I trust these BIOs are known to only contain suitably-allocated, MD-private
pages? Because if these pages can be user pages then this change is
spectacularly buggy ;)
Your trust is well placed.
This is in the 'resync' path, were all buffers are allocated in lowmem
and are full pages and so-forth, so this is perfectly safe.
NeilBrown