Thread (5 messages) 5 messages, 3 authors, 2006-12-22

Re: [patch] latency problem in md driver

From: Ric Wheeler <hidden>
Date: 2006-12-22 15:37:14

Jeff Garzik wrote:
Lars Ellenberg wrote:
quoted
md raidX make_request functions strip off the BIO_RW_SYNC flag,
this introducing additional latency.

below is a suggested patch for the raid1.c .
other suggested solutions would be to let the bio_clone do its work,
and not reassign thereby stripping off all flags.
at most strip off known unwanted flags (the BARRIER flag).
It sounds like a major bug to strip the barrier flag.  I quite 
understand that a barrier to a RAID device as a whole behaves 
differently from a barrier to an ATA or SCSI device, but that's no 
excuse to avoid the problem.

If MD does not pass barriers, it is unilaterally dropping the "data made 
it to the media" guarantee.

    Jeff
Exactly right - if we do not pass the barrier request down to the 
members of the RAID group, then we lose the data integrity needed.

Of course, in a RAID group, this will be introduce latency, but that is 
the correct behavior.

ric
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help