Re: [PATCH] bio: set bi_idx after bio cloning
From: Jens Axboe <hidden>
Date: 2005-05-23 07:31:32
On Mon, May 16 2005, Mike Tran wrote:
quoted hunk ↗ jump to hunk
Hi Jens, Unless you have specific reason for not doing in __bio_clone(), I agree with Neil's suggestion. Please consider the following patch:--- linux-2.6.12-rc4-orig/fs/bio.c 2005-05-16 10:13:27.000000000 -0500 +++ linux-2.6.12-rc4-patch/fs/bio.c 2005-05-16 10:15:06.000000000 -0500@@ -255,10 +255,7 @@ bio->bi_flags |= 1 << BIO_CLONED; bio->bi_rw = bio_src->bi_rw; - /* - * notes -- maybe just leave bi_idx alone. assume identical mapping - * for the clone - */ + bio->bi_idx = bio_src->bi_idx; bio->bi_vcnt = bio_src->bi_vcnt; bio->bi_size = bio_src->bi_size; bio_phys_segments(q, bio);
That patch is fine with me, I'll add it. Thanks. -- Jens Axboe