Re: [PATCH] Version 1 super block

On Sun, 2005-01-23 at 19:38, Neil Brown wrote:

On Friday January 21, mhtran@us.ibm.com wrote:

quoted

Hello Neil,

I've been wondering if you had a chance to look at this patch.  Please
let me know.

No I hadn't, but I have now.

quoted

On Sat, 2005-01-15 at 20:50, Mike Tran wrote:

quoted

Hello Neil,

I found 2 problems in the kernel MD driver:
1) if disk index 0 is used, counting of max_dev is wrong

Yes, but I think that the correct fix is simply to add 1 to max_dev,
rather than setting it to max(max_dev, i).
It should really be renamed to "max_devs" (i.e. the maximum number of
devices) rather than "max_dev" (i.e. the maximum device number).
Possibly "num_slots" wold be an even better name...

quoted

quoted

2) missing checksum calculation

Yes .... how did I miss that :-(

quoted

quoted

Please consider the attached patch for 2.6.10 kernel.

How about the following?
I'll add a changelog entry and forward it to Andrew shortly.

sounds good.

Thanks,
Mike T.