Re: Problem with raid1 read error patch

On Mon, 2004-09-20 at 17:28, Paul Clements wrote:

Hi Paul

quoted

After backing that patch out, with some minor modifications because the
code has changed a little bit, I get a number of scsi-errors and after a
while the drive gets disabled like above but life continues like before
the patch went in. That is, no infinite loop and everything works :)

Any ideas to what went wrong?

Yes. You're getting the infinite retries because the BIO_UPTODATE flag 
in the bio is not set.

Ah

I've been debugging the same problem just recently. In addition to this 
patch from Neil, you'll also need a patch that I posted here last week, 
which does a bio_put() and a bio_clone() to get rid of the old bio that 
the read error occurred on, and create a new (clean) bio to retry the 
read against:

http://marc.theaimsgroup.com/?l=linux-raid&m=109527014728404&w=2

Thanks, will try it out tomorrow when I'm back in front of the machine.
Didn't expect an answer so soon :)

-- 
/Martin