Thread (1 message) 1 message, 1 author, 2003-03-13

Re: Small fix for 2.4 md.c - using device information before lock_dev()

From: Neil Brown <hidden>
Date: 2003-03-13 00:54:27

On Wednesday March 12, lmb@suse.de wrote:
Good morning,

I've been testing md under UML. It appears that UML is exposing a minor bug in
md.c: it is trying to use information about the device (in particular,
blk_sizes[]) before having imported it (which calls lock_dev() and thus makes
the information available in the first place).

This was exposed because UML resets the blk_sizes[] information to zero on
ubd_release().

Working patch attached; it just reorders the function calls. Please apply to
2.4 if appropriate.
Thanks ... that's a subtle one.  
It appears not be be an issue with 2.5 as you cannot even get at the
size before doing the bdget - which is good.

I'll send it to Marcelo.

NeilBrown
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help