Thread (7 messages) 7 messages, 3 authors, 2021-09-20

[PATCH 2/2] pwm: renesas-tpu: don't allow no duty if duty_ns is given

From: Wolfram Sang <wsa+renesas@sang-engineering.com>
Date: 2021-09-15 06:55:54
Also in: linux-renesas-soc, lkml
Subsystem: pwm subsystem, the rest · Maintainers: Uwe Kleine-König, Linus Torvalds

From: Duc Nguyen <redacted>

We have special code if duty_ns is 0. But if non-zero is given, then the
calculation should not result in zero duty.

Signed-off-by: Duc Nguyen <redacted>
[wsa: split and reworded commit message]
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/pwm/pwm-renesas-tpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pwm/pwm-renesas-tpu.c b/drivers/pwm/pwm-renesas-tpu.c
index 754440194650..bb51156e4bda 100644
--- a/drivers/pwm/pwm-renesas-tpu.c
+++ b/drivers/pwm/pwm-renesas-tpu.c
@@ -275,7 +275,7 @@ static int tpu_pwm_config(struct pwm_chip *chip, struct pwm_device *_pwm,
 	if (duty_ns) {
 		duty = clk_rate / prescalers[prescaler]
 		     / (NSEC_PER_SEC / duty_ns);
-		if (duty > period)
+		if (duty > period || duty == 0)
 			return -EINVAL;
 	} else {
 		duty = 0;
-- 
2.30.2
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help