Thread (7 messages) 7 messages, 1 author, 29d ago

[PATCH 3/5] power: supply: bq257xx: Don't ignore errors from bq257xx_get_state()

flat view
COLD29d

From: Alexey Charkov <hidden>
Date: 2026-09-07 15:01:59
Also in: lkml
Subsystem: power supply class/subsystem and drivers, the rest · Maintainers: Sebastian Reichel, Linus Torvalds

The callback function bq257xx_get_state() can return an error code when
its regmap access fails, but its caller bq257xx_external_power_changed()
was ignoring those.

Return early on errors and propagate the error code to the caller.

Fixes: 1cc017b7f9c7 ("power: supply: bq257xx: Add support for BQ257XX charger")
Signed-off-by: Alexey Charkov <redacted>
---
 drivers/power/supply/bq257xx_charger.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/power/supply/bq257xx_charger.c b/drivers/power/supply/bq257xx_charger.c
index b735bb02a8e0..355c59f0bbfb 100644
--- a/drivers/power/supply/bq257xx_charger.c
+++ b/drivers/power/supply/bq257xx_charger.c
@@ -1053,7 +1053,9 @@ static void bq257xx_external_power_changed(struct power_supply *psy)
 	int ret;
 	int imax = pdata->iindpm_max;
 
-	pdata->chip->bq257xx_get_state(pdata);
+	ret = pdata->chip->bq257xx_get_state(pdata);
+	if (ret)
+		return;
 
 	pdata->supplied = power_supply_am_i_supplied(pdata->charger);
 	if (pdata->supplied < 0)
-- 
2.54.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help