Re: [PATCH 07/20] interconnect: qcom: Fold smd-rpm.h into icc-rpm.h
From: Konrad Dybcio <hidden>
Date: 2023-06-01 10:09:35
Also in:
linux-arm-msm, linux-clk, lkml
On 1.06.2023 12:04, Dmitry Baryshkov wrote:
On 01/06/2023 13:00, Konrad Dybcio wrote:quoted
On 1.06.2023 11:57, Dmitry Baryshkov wrote:quoted
On 30/05/2023 13:20, Konrad Dybcio wrote:quoted
smd-rpm.h is not very useful as-is and both files are always included anyway.. Combine them.If we ever add interconnect driver for non-SMD RPM platforms (like MSM8960/APQ8064), we can just ignore the smd part.icc-rpm sends requests via smd so that doesn't sound unifiableAck. Should we rename it to icc-smd-rpm.c while doing the merge?
I'd stay it's fine if it stays as-is for now, until (if) somebody tackles "old" RPM. Konrad
quoted
Konradquoted
quoted
Signed-off-by: Konrad Dybcio <redacted> --- drivers/interconnect/qcom/icc-rpm.c | 1 - drivers/interconnect/qcom/icc-rpm.h | 5 +++++ drivers/interconnect/qcom/msm8916.c | 1 - drivers/interconnect/qcom/msm8939.c | 1 - drivers/interconnect/qcom/msm8974.c | 2 +- drivers/interconnect/qcom/msm8996.c | 1 - drivers/interconnect/qcom/qcm2290.c | 1 - drivers/interconnect/qcom/qcs404.c | 1 - drivers/interconnect/qcom/sdm660.c | 1 - drivers/interconnect/qcom/smd-rpm.c | 2 +- drivers/interconnect/qcom/smd-rpm.h | 15 --------------- 11 files changed, 7 insertions(+), 24 deletions(-)Reviewed-by: Dmitry Baryshkov <redacted>