Re: (EXT) Re: (EXT) Re: [PATCH 1/1] thermal: imx8mm: enable ADC when enabling monitor

Am Mittwoch, dem 01.12.2021 um 15:52 +0100 schrieb Daniel Lezcano:

On 01/12/2021 15:45, Alexander Stein wrote:

quoted

Am Dienstag, dem 30.11.2021 um 15:49 +0100 schrieb Daniel Lezcano:

quoted

On 22/11/2021 12:42, Alexander Stein wrote:

quoted

From: Paul Gerber <
Paul.Gerber@tq-group.com


The i.MX 8MP has a ADC_PD bit in the TMU_TER register that
controls
the
operating mode of the ADC:
* 0 means normal operating mode
* 1 means power down mode

When enabling/disabling the TMU, the ADC operating mode must be
set
accordingly.

i.MX 8M Mini & Nano are lacking this bit.

Signed-off-by: Paul Gerber <
Paul.Gerber@tq-group.com


Signed-off-by: Alexander Stein <
alexander.stein@ew.tq-group.com


---
Often this bit is set already by the bootloader, but in case
this
is not
done, the file /sys/class/thermal/thermal_zone0/temp will
always
return
-EAGAIN.

Does it deserve a Fixes tag?

The more I think about it, the more I'm inclined to add one.
Please tell me if I shall iterate v2 adding a Fixes tag (or other
changes)

It is not necessary to send a V2 as the commit log will have a link
to
this thread. Just answer with the Fixes tag, I'll add it myself to
the
change log.

Thanks.

Fixes: 2b8f1f0337c5 ("thermal: imx8mm: Add i.MX8MP support")

imx8mm_tmu_enable() was introduced in this commit and the fix is about
i.MX8MP as well, so this seems even more reasonable to me.

Best regards,
Alexander