Re: [PATCH v2] extcon: fix extcon_get_extcon_dev() error handling
From: Dan Carpenter <hidden>
Date: 2021-12-16 07:53:26
Also in:
kernel-janitors, linux-omap, linux-usb, lkml
From: Dan Carpenter <hidden>
Date: 2021-12-16 07:53:26
Also in:
kernel-janitors, linux-omap, linux-usb, lkml
On Thu, Dec 16, 2021 at 03:39:46PM +0900, Chanwoo Choi wrote:
Hi Dan, First of all, sorry for late reply. There is one issue. About this issue, I already discussed on patch[1] [1] https://lore.kernel.org/lkml/5BEB63C3.1020504@samsung.com/ (local) extcon_get_extcon_dev() is used for anywhere except for probe step. But EPROBE_DEFER is only used on probe step. So that it is not clear to return EPROBE_DEFER from extcon_get_extcon_dev() because extcon_get_extcon_dev() never know either call it on probe function or not.
Currently extcon_get_extcon_dev() is only called from probe so it's not an issue. It's impossible to know what future programmers will want, but I feel like this change probably makes it easier for them. regards, dan carpenter