Thread (8 messages) 8 messages, 2 authors, 2021-11-24

AMD Pstate

From: Mike Lothian <hidden>
Date: 2021-11-21 10:38:15
Subsystem: the rest, x86 architecture (32-bit and 64-bit) · Maintainers: Linus Torvalds, Thomas Gleixner, Ingo Molnar, Borislav Petkov, Dave Hansen

Hi

I'm not subscribed to the mailing list so apologies for emailing you directly

It looks like something isn't quite right with the kconfig selects

SCHED_MC_PRIO can't be enabled without CPU_SUP_INTEL



│ Symbol: X86_AMD_PSTATE [=y]

                                                              │
 │ Type  : bool

                                                               │
 │ Defined at drivers/cpufreq/Kconfig.x86:37

                                                               │
 │   Prompt: AMD Processor P-State driver

                                                               │
 │   Depends on: CPU_FREQ [=y] && X86 [=y]

                                                               │
 │   Location:

                                                               │
 │     Main menu

                                                               │
 │       -> Power management and ACPI options

                                                               │
 │         -> CPU Frequency scaling

                                                               │
 │           -> CPU Frequency scaling (CPU_FREQ [=y])

                                                               │
 │ Selects: ACPI_PROCESSOR [=y] && ACPI_CPPC_LIB [=n] &&
CPU_FREQ_GOV_SCHEDUTIL [=y]



│ Symbol: ACPI_CPPC_LIB [=n]

                                                              │
 │ Type  : bool

                                                               │
 │ Defined at drivers/acpi/Kconfig:268

                                                               │
 │   Depends on: ACPI [=y] && ACPI_PROCESSOR [=y]

                                                               │
 │ Selects: MAILBOX [=n] && PCC [=n]

                                                               │
 │ Selected by [n]:

                                                               │
 │   - X86_INTEL_PSTATE [=n] && CPU_FREQ [=y] && X86 [=y] && X86_64
[=y] && ACPI [=y] && SCHED_MC_PRIO [=n]
                                                                  │
 │   - X86_AMD_PSTATE [=y] && CPU_FREQ [=y] && X86 [=y] && X86_64 [=y]
&& ACPI [=y] && SCHED_MC_PRIO [=n]
                                                               │
 │   - ACPI_CPPC_CPUFREQ [=n] && CPU_FREQ [=y] && (ARM || ARM64) &&
ACPI_PROCESSOR [=y]



│ Symbol: SCHED_MC_PRIO [=n]

                                                              │
 │ Type  : bool

                                                               │
 │ Defined at arch/x86/Kconfig:1029

                                                               │
 │   Prompt: CPU core priorities scheduler support

                                                               │
 │   Depends on: SCHED_MC [=y] && CPU_SUP_INTEL [=n]

                                                               │
 │   Location:

                                                               │
 │     Main menu

                                                               │
 │       -> Processor type and features

                                                               │
 │ (1)     -> Multi-core scheduler support (SCHED_MC [=y])

                                                               │
 │ Selects: X86_INTEL_PSTATE [=n] && CPU_FREQ [=y]



I've used this patch to work around the issue:
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 95dd1ee01546..bdfcf155f48e 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -1028,8 +1028,8 @@ config SCHED_MC
config SCHED_MC_PRIO
       bool "CPU core priorities scheduler support"
-       depends on SCHED_MC && CPU_SUP_INTEL
-       select X86_INTEL_PSTATE
+       depends on SCHED_MC && CPU_SUP_AMD
+       select X86_AMD_PSTATE
       select CPU_FREQ
       default y
       help

Which gets things working here
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help