Re: [PATCH 00/16] AB8500 charger to use power_supply_battery_info
From: Sebastian Reichel <hidden>
Date: 2021-11-18 17:14:33
Hi, On Thu, Nov 18, 2021 at 03:17:36AM +0100, Linus Walleij wrote:
This is the first set of patches starting to migrate the AB8500 charging code to use the struct power_supply_battery_info. We drop some cruft along the road. This series does not add anything to the struct, just reuse what is already there. Adding new stuff comes in the next patch series. The AB8500 charging code has not been in working condition for some time, but it is slowly getting there. Some of this is just regular maintenance. Linus Walleij (16): power: supply: ab8500: Use core battery parser power: supply: ab8500: Sink current tables into charger code power: supply: ab8500: Standardize operating temperature power: supply: ab8500: Drop unused battery types power: supply: ab8500: Use only one battery type power: supply: ab8500: Standardize design capacity power: supply: ab8500: Standardize technology power: supply: ab8500: Standardize voltages power: supply: ab8500_fg: Init battery data in bind() power: supply: ab8500: Standardize internal resistance power: supply: ab8500: Standardize termination current power: supply: ab8500: Make recharge capacity a constant power: supply: ab8500: Standardize CC current power: supply: ab8500: Standardize CV voltage power: supply: ab8500: Standardize temp res lookup power: supply: ab8500: Standardize capacity lookup drivers/power/supply/ab8500-bm.h | 121 +----- drivers/power/supply/ab8500-chargalg.h | 8 +- drivers/power/supply/ab8500_bmdata.c | 566 ++++++------------------- drivers/power/supply/ab8500_btemp.c | 61 ++- drivers/power/supply/ab8500_chargalg.c | 315 +++++++------- drivers/power/supply/ab8500_charger.c | 536 ++++++++++++----------- drivers/power/supply/ab8500_fg.c | 371 ++++++++-------- 7 files changed, 796 insertions(+), 1182 deletions(-)
Apart from my comments to patch 1 (which also affects patch 3 due to the moved scope of the battery info data) the series looks good to me. -- Sebastian
Attachments
- signature.asc [application/pgp-signature] 833 bytes