Re: [PATCH v4 22/25] memory: emif: Use kernel_can_power_off()
From: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Date: 2021-11-28 01:25:53
Also in:
linux-acpi, linux-m68k, linux-mips, linux-riscv, linux-sh, linux-tegra, linuxppc-dev, lkml, xen-devel
On Fri, Nov 26, 2021 at 09:00:58PM +0300, Dmitry Osipenko wrote:
quoted hunk ↗ jump to hunk
Replace legacy pm_power_off with kernel_can_power_off() helper that is aware about chained power-off handlers. Signed-off-by: Dmitry Osipenko <digetx@gmail.com> --- drivers/memory/emif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/memory/emif.c b/drivers/memory/emif.c index 762d0c0f0716..cab10d5274a0 100644 --- a/drivers/memory/emif.c +++ b/drivers/memory/emif.c@@ -630,7 +630,7 @@ static irqreturn_t emif_threaded_isr(int irq, void *dev_id) dev_emerg(emif->dev, "SDRAM temperature exceeds operating limit.. Needs shut down!!!\n"); /* If we have Power OFF ability, use it, else try restarting */ - if (pm_power_off) { + if (kernel_can_power_off()) { kernel_power_off(); } else { WARN(1, "FIXME: NO pm_power_off!!! trying restart\n");
BTW, this part of the code seems to be better moved to generic code that could replace POWER_OFF request with REBOOT like it is done for reboot() syscall. Best Regards Michał Mirosław