On Fri, Nov 19, 2021 at 07:16:05PM +0800, Huang Rui wrote:

On Fri, Nov 19, 2021 at 06:46:58PM +0800, Peter Zijlstra wrote:

quoted

On Fri, Nov 19, 2021 at 06:30:46PM +0800, Huang Rui wrote:

quoted

+static inline int pstate_enable(bool enable)
+{
+	return wrmsrl_safe(MSR_AMD_CPPC_ENABLE, enable ? 1 : 0);

Strictly speaking that ?: is superfluous, a _Bool when cast to scalar
type will have exactly that value.

Right. Will update it to "wrmsrl_safe(MSR_AMD_CPPC_ENABLE, enable)".

I think there was one more site that did this. You don't *need* to
change it, but it's something I noted while reading through the thing.

Over-all I think the series looks nice. Thanks for doing this.