Hi,

On Wed, Oct 13, 2021 at 01:49:19PM +0200, Hans de Goede wrote:

On 10/13/21 11:31 AM, Wei Yongjun wrote:

quoted

The driver allocates the mutex but not initialize it.
Use mutex_init() on it to initialize it correctly.

Fixes: ed229454856e ("power: supply: axp288-charger: Optimize register reading method")
Reported-by: Hulk Robot <redacted>
Signed-off-by: Wei Yongjun <redacted>

Thanks, patch looks good to me
(I should have catched this myself during review...) :

Reviewed-by: Hans de Goede <redacted>

Thanks, queued.

-- Sebastian

quoted

---
 drivers/power/supply/axp288_charger.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/power/supply/axp288_charger.c b/drivers/power/supply/axp288_charger.c
index fd4983c98fd9..9987b1731e38 100644
--- a/drivers/power/supply/axp288_charger.c
+++ b/drivers/power/supply/axp288_charger.c

@@ -865,6 +865,7 @@ static int axp288_charger_probe(struct platform_device *pdev)
 	if (!info)
 		return -ENOMEM;
 
+	mutex_init(&info->lock);
 	info->pdev = pdev;
 	info->regmap = axp20x->regmap;
 	info->regmap_irqc = axp20x->regmap_irqc;