15.09.2021 21:23, Chanwoo Choi пишет:

On 21. 9. 13. 오전 3:44, Dmitry Osipenko wrote:

quoted

Add resource-managed variant of devfreq_add_governor().

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
  drivers/devfreq/devfreq.c  | 26 ++++++++++++++++++++++++++
  drivers/devfreq/governor.h |  3 +++
  2 files changed, 29 insertions(+)

diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
index 85faa7a5c7d1..d3af000ec290 100644
--- a/drivers/devfreq/devfreq.c
+++ b/drivers/devfreq/devfreq.c

@@ -1301,6 +1301,32 @@ int devfreq_add_governor(struct

devfreq_governor *governor)
  }
  EXPORT_SYMBOL(devfreq_add_governor);
  +static void devm_devfreq_remove_governor(void *governor)
+{
+    devfreq_remove_governor(governor);

Because devfreq_remove_governor has the return value,
you need to check the return value and then print error at least.

    WARN_ON(devfreq_remove_governor(governor));

...

quoted

diff --git a/drivers/devfreq/governor.h b/drivers/devfreq/governor.h
index 2d69a0ce6291..0d70a9ad951e 100644
--- a/drivers/devfreq/governor.h
+++ b/drivers/devfreq/governor.h

@@ -94,4 +94,7 @@ static inline int devfreq_update_stats(struct

devfreq *df)
        return df->profile->get_dev_status(df->dev.parent,
&df->last_status);
  }
+
+int devm_devfreq_add_governor(struct device *dev,
+                  struct devfreq_governor *governor);

Better to add under devfreq_remove_governor definition in order to
gather the similar functions.

I'll change it in v2, thanks.