Re: [PATCH] kernel/power: Remove blk_status_to_errno in hib_wait_io

From
Rafael J. Wysocki <rafael@kernel.org>
Date
2021-09-15 12:18:46
Also in
lkml
Reply to
Falla Coulibaly, 2021-08-18
On Wed, Aug 18, 2021 at 11:48 PM Falla Coulibaly
[off-list ref] wrote:
quoted hunk ↗ jump to hunk
blk_status_to_errno doesn't appear to perform extra work besides
converting blk_status_t to integer. This patch removes that unnecessary
conversion as the return type of the function is blk_status_t.

Signed-off-by: Falla Coulibaly <redacted>
---
 kernel/power/swap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/power/swap.c b/kernel/power/swap.c
index 3cb89baebc79..9ec418955556 100644
--- a/kernel/power/swap.c
+++ b/kernel/power/swap.c
@@ -306,7 +306,7 @@ static blk_status_t hib_wait_io(struct hib_bio_batch *hb)
         * a plug will flush the plug list before sleeping.
         */
        wait_event(hb->wait, atomic_read(&hb->count) == 0);
-       return blk_status_to_errno(hb->error);
+       return hb->error;
 }

 /*
--
Applied as 5.16 material, thanks!
Thread (2 messages) 2 messages, 2 authors, last reply 2021-09-15
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help