Re: [PATCH v5 5/8] cpufreq: Add an interface to mark inefficient frequencies

Hi Vincent,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on next-20210825]
[cannot apply to pm/linux-next linus/master v5.14-rc7 v5.14-rc6 v5.14-rc5 v5.14-rc7]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Vincent-Donnefort/inefficient-OPPs/20210826-163705
base:    7636510f976d75b860848884169ba985c8f844d8
config: i386-randconfig-r025-20210826 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project ea08c4cd1c0869ec5024a8bb3f5cdf06ab03ae83)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/ed31a82b6d4abef95e8c50df33f826175cb6b6de
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Vincent-Donnefort/inefficient-OPPs/20210826-163705
        git checkout ed31a82b6d4abef95e8c50df33f826175cb6b6de
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <redacted>

All errors (new ones prefixed by >>):

   In file included from kernel/time/tick-common.c:19:
   In file included from include/trace/events/power.h:8:

quoted

include/linux/cpufreq.h:1044:35: error: non-void function does not return a value [-Werror,-Wreturn-type]

                                 unsigned int frequency) {}
                                                          ^
   1 error generated.
--
   In file included from drivers/acpi/processor_idle.c:23:
   In file included from include/acpi/processor.h:7:

quoted

include/linux/cpufreq.h:1044:35: error: non-void function does not return a value [-Werror,-Wreturn-type]

                                 unsigned int frequency) {}
                                                          ^
   drivers/acpi/processor_idle.c:1137:12: warning: no previous prototype for function 'acpi_processor_ffh_lpi_probe' [-Wmissing-prototypes]
   int __weak acpi_processor_ffh_lpi_probe(unsigned int cpu)
              ^
   drivers/acpi/processor_idle.c:1137:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int __weak acpi_processor_ffh_lpi_probe(unsigned int cpu)
   ^
   static 
   drivers/acpi/processor_idle.c:1142:12: warning: no previous prototype for function 'acpi_processor_ffh_lpi_enter' [-Wmissing-prototypes]
   int __weak acpi_processor_ffh_lpi_enter(struct acpi_lpi_state *lpi)
              ^
   drivers/acpi/processor_idle.c:1142:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int __weak acpi_processor_ffh_lpi_enter(struct acpi_lpi_state *lpi)
   ^
   static 
   2 warnings and 1 error generated.
--
   In file included from kernel/sched/topology.c:5:
   In file included from kernel/sched/sched.h:43:

quoted

include/linux/cpufreq.h:1044:35: error: non-void function does not return a value [-Werror,-Wreturn-type]

                                 unsigned int frequency) {}
                                                          ^
   kernel/sched/topology.c:691:6: warning: variable 'numa_distance' set but not used [-Wunused-but-set-variable]
           int numa_distance = 0;
               ^
   1 warning and 1 error generated.
--
   In file included from kernel/sched/core.c:13:
   In file included from kernel/sched/sched.h:43:

quoted

include/linux/cpufreq.h:1044:35: error: non-void function does not return a value [-Werror,-Wreturn-type]

                                 unsigned int frequency) {}
                                                          ^
   kernel/sched/core.c:3217:6: warning: no previous prototype for function 'sched_set_stop_task' [-Wmissing-prototypes]
   void sched_set_stop_task(int cpu, struct task_struct *stop)
        ^
   kernel/sched/core.c:3217:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   void sched_set_stop_task(int cpu, struct task_struct *stop)
   ^
   static 
   1 warning and 1 error generated.
--
   In file included from kernel/sched/fair.c:23:
   In file included from kernel/sched/sched.h:43:

quoted

include/linux/cpufreq.h:1044:35: error: non-void function does not return a value [-Werror,-Wreturn-type]

                                 unsigned int frequency) {}
                                                          ^
   kernel/sched/fair.c:10924:6: warning: no previous prototype for function 'task_vruntime_update' [-Wmissing-prototypes]
   void task_vruntime_update(struct rq *rq, struct task_struct *p, bool in_fi)
        ^
   kernel/sched/fair.c:10924:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   void task_vruntime_update(struct rq *rq, struct task_struct *p, bool in_fi)
   ^
   static 
   1 warning and 1 error generated.
--
   In file included from kernel/sched/rt.c:6:
   In file included from kernel/sched/sched.h:43:

quoted

include/linux/cpufreq.h:1044:35: error: non-void function does not return a value [-Werror,-Wreturn-type]

                                 unsigned int frequency) {}
                                                          ^
   kernel/sched/rt.c:669:6: warning: no previous prototype for function 'sched_rt_bandwidth_account' [-Wmissing-prototypes]
   bool sched_rt_bandwidth_account(struct rt_rq *rt_rq)
        ^
   kernel/sched/rt.c:669:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   bool sched_rt_bandwidth_account(struct rt_rq *rt_rq)
   ^
   static 
   1 warning and 1 error generated.


vim +1044 include/linux/cpufreq.h

  1041	
  1042	static inline int
  1043	cpufreq_table_set_inefficient(const struct cpufreq_policy *policy,

1044				      unsigned int frequency) {}

  1045	#endif
  1046	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org