Re: [PATCH v2 08/10] power: supply: axp288_fuel_gauge: Refresh all registers in one go
From: Hans de Goede <hidden>
Date: 2021-08-01 11:23:48
Also in:
oe-kbuild-all
Hi, On 7/30/21 6:14 PM, kernel test robot wrote:
Hi Hans, Thank you for the patch! Yet something to improve: [auto build test ERROR on power-supply/for-next] [also build test ERROR on v5.14-rc3 next-20210729] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Hans-de-Goede/power-supply-axp288_fuel_gauge-Reduce-number-of-register-accesses-cleanups/20210730-175716 base: https://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply.git for-next config: x86_64-buildonly-randconfig-r001-20210730 (attached as .config) compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 4f71f59bf3d9914188a11d0c41bedbb339d36ff5) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/1ff192ccce54fdfce899447999a60a195537460c git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Hans-de-Goede/power-supply-axp288_fuel_gauge-Reduce-number-of-register-accesses-cleanups/20210730-175716 git checkout 1ff192ccce54fdfce899447999a60a195537460c # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <redacted> All errors (new ones prefixed by >>):quoted
quoted
drivers/power/supply/axp288_fuel_gauge.c:219:8: error: implicit declaration of function 'iosf_mbi_block_punit_i2c_access' [-Werror,-Wimplicit-function-declaration]ret = iosf_mbi_block_punit_i2c_access(); ^quoted
quoted
drivers/power/supply/axp288_fuel_gauge.c:268:2: error: implicit declaration of function 'iosf_mbi_unblock_punit_i2c_access' [-Werror,-Wimplicit-function-declaration]iosf_mbi_unblock_punit_i2c_access(); ^ drivers/power/supply/axp288_fuel_gauge.c:268:2: note: did you mean 'iosf_mbi_block_punit_i2c_access'? drivers/power/supply/axp288_fuel_gauge.c:219:8: note: 'iosf_mbi_block_punit_i2c_access' declared here ret = iosf_mbi_block_punit_i2c_access(); ^ 2 errors generated.
Ugh, so I guess that it is possible to build a x86 kernel without iosf_mbi support enabled. Given how the I2C bus to PMIC is special on devices with an AXP288 PMIC and special attention must be made to coordinate accesses with the SoC-s P-Unit, allowing building of the AXP288 code without IOSF_MBi makes little sense (this will lead to a very unreliable kernel build) so I'll do a v3 changing the new depends on from X86 to IOSF_MBI. Sorry about all the churn because of this Kconfig depends issue. Regards, Hans