Thread (6 messages) 6 messages, 4 authors, 2021-09-09

Re: [PATCH] thermal: qcom: spmi-adc-tm5: Don't abort probing if a sensor is not used

From: Stephen Boyd <hidden>
Date: 2021-08-23 23:50:42
Also in: linux-arm-msm, lkml

Quoting Matthias Kaehlcke (2021-08-23 13:47:30)
adc_tm5_register_tzd() registers the thermal zone sensors for all
channels of the thermal monitor. If the registration of one channel
fails the function skips the processing of the remaining channels
and returns an error, which results in _probe() being aborted.

One of the reasons the registration could fail is that none of the
thermal zones is using the channel/sensor, which hardly is a critical
error (if it is an error at all). If this case is detected emit a
warning and continue with processing the remaining channels.

Fixes: ca66dca5eda6 ("thermal: qcom: add support for adc-tm5 PMIC thermal monitor")
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
---
Reported-by: Stephen Boyd <redacted>
Reviewed-by: Stephen Boyd <redacted>

Should we also disable the 'charger-thermistor@0' node in
sc7180-trogdor.dtsi on lazor boards, instead of the thermal zone, or in
addition to the thermal zone? It isn't used so there's not much value in
exposing it.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help