Re: [PATCH V2 9/9] cpufreq: scmi: Use .register_em() callback
From: Quentin Perret <hidden>
Date: 2021-08-11 13:17:52
Also in:
linux-arm-kernel, lkml
On Wednesday 11 Aug 2021 at 17:28:47 (+0530), Viresh Kumar wrote:
quoted hunk ↗ jump to hunk
Set the newly added .register_em() callback to register with the EM after the cpufreq policy is properly initialized. Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> --- drivers/cpufreq/scmi-cpufreq.c | 55 ++++++++++++++++++++-------------- 1 file changed, 32 insertions(+), 23 deletions(-)diff --git a/drivers/cpufreq/scmi-cpufreq.c b/drivers/cpufreq/scmi-cpufreq.c index 75f818d04b48..b916c9e22921 100644 --- a/drivers/cpufreq/scmi-cpufreq.c +++ b/drivers/cpufreq/scmi-cpufreq.c@@ -22,7 +22,9 @@ struct scmi_data { int domain_id; + int nr_opp; struct device *cpu_dev; + cpumask_var_t opp_shared_cpus;
Can we use policy->related_cpus and friends directly in the callback instead? That should simplify the patch a bit. Also, we can probably afford calling dev_pm_opp_get_opp_count() from the em_register callback as it is not a hot path, which would avoid wasting some 'resident' memory here that is only used during init. Thanks, Quentin