Re: [PATCH v1 2/2] PCI: PM: Enable PME if it can be signaled from D3cold
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: 2021-07-30 12:13:25
Also in:
linux-acpi, linux-pci, lkml
On Fri, Jul 30, 2021 at 12:28 PM Mika Westerberg [off-list ref] wrote:
On Thu, Jul 29, 2021 at 04:49:10PM +0200, Rafael J. Wysocki wrote:quoted
From: Rafael J. Wysocki <redacted> PME signaling is only enabled by __pci_enable_wake() if the target device can signal PME from the given target power state (to avoid pointless reconfiguration of the device), but if the hierarchy above the device goes into D3cold, the device itself will end up in D3cold too, so if it can signal PME from D3cold, it should be enabled to do so in __pci_enable_wake(). [Note that if the device does not end up in D3cold and it cannot signal PME from the original target power state, it will not signal PME, so in that case the behavior does not change.] Link: https://lore.kernel.org/linux-pm/3149540.aeNJFYEL58@kreacher/ (local) Fixes: 5bcc2fb4e815 ("PCI PM: Simplify PCI wake-up code") Reported-by: Mika Westerberg <mika.westerberg@linux.intel.com>Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com> Also this solves the reported issue so, Tested-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Thank you! I'll queue up these two patches for 5.15 barring any objections from Bjorn.