Thread (3 messages) 3 messages, 3 authors, 2021-07-26

Re: [PATCH] interconnect: qcom: osm-l3: Use driver-specific naming

From: Stephen Boyd <hidden>
Date: 2021-07-26 23:02:09
Also in: linux-arm-msm, lkml

Quoting Bjorn Andersson (2021-07-24 20:14:14)
In situations were the developer screws up by e.g. not giving the OSM
nodes unique identifiers the interconnect framework might mix up nodes
between the OSM L3 provider and e.g. the RPMh provider.

The resulting callstack containts "qcom_icc_set", which is not unique to
the OSM L3 provider driver. Once the faulting qcom_icc_set() is
identified it's further confusing that "qcom_icc_node" is different
between the different drivers.

To avoid this confusion, rename the node struct and the setter in the
OSM L3 driver to include "osm_l3" in their names.

Signed-off-by: Bjorn Andersson <redacted>
---
Thanks

Reviewed-by: Stephen Boyd <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help