Re: [PATCH v6 9/9] dt-bindings: cpufreq: qcom-hw: Make reg-names a required property
From: Rob Herring <robh@kernel.org>
Date: 2021-07-13 22:42:52
Also in:
linux-devicetree, lkml, phone-devel
On Thu, Jul 01, 2021 at 12:57:30PM +0200, AngeloGioacchino Del Regno wrote:
The property reg-names is required after the addition of the OSM programming sequence, as that mandates specifying different register domains; to avoid confusion and improve devicetree readability, specifying the regions names was made mandatory.
Can't take patches missing a S-o-b. Making existing properties required breaks compatibility. That's okay on *all* the platforms using this? If so, that needs to be crystal clear in the commit msg.
quoted hunk ↗ jump to hunk
--- Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml | 1 + 1 file changed, 1 insertion(+)diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml b/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml index 29b663321a0b..17fd6a6cefb0 100644 --- a/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml +++ b/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml@@ -98,6 +98,7 @@ else: required: - compatible - reg + - reg-names - clocks - clock-names - '#freq-domain-cells'-- 2.32.0