Thread (7 messages) 7 messages, 3 authors, 2021-07-12

Re: [PATCH v2 2/2] power: supply: rn5t618: Add voltage_now property

From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
Date: 2021-07-12 10:15:43
Also in: linux-iio, lkml

On Mon, 12 Jul 2021 09:11:30 +0200
Andreas Kemnade [off-list ref] wrote:
On Sun, 11 Jul 2021 11:20:39 +0100
Jonathan Cameron [off-list ref] wrote:
quoted
On Mon,  5 Jul 2021 13:36:37 +0200
Andreas Kemnade [off-list ref] wrote:
  
quoted
Read voltage_now via IIO and provide the property.

Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
Reported-by: kernel test robot <redacted>    
Huh?  Seems unlikely it pointed out that this patch was necessary in general.
If highlighting a particular fix in an earlier version, then state what it was
in the commit message. Note for fixes that get rolled into patches, it's
often just mentioned in the change log and we skip the tag because it can
cause confusion.
  
The robot found a problem in v1 (missing depends on IIO). It is fixed
now. The message from the bot tells to add a tag. It seems not to make
sense. But probably the bot is also running on public branches (which
will not be rebase) and uses the same message where it actually makes
sense.
Yup. It might be helpful if they modified that message to suggest
commented format if the fix is rolled into an existing patch.  I've seen
things like.

Reported-by: kernel test robot <redacted> # Fix something interesting.

Which makes it clear what is going on.

Jonathan
I will send a v3 with that tag removed and the other comment addressed.

Regards,
Andreas
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help