+Lukasz,

On 09-07-21, 11:37, Thara Gopinath wrote:

On 7/9/21 2:46 AM, Viresh Kumar wrote:

quoted

On 08-07-21, 08:06, Thara Gopinath wrote:

quoted

  static int qcom_cpufreq_hw_cpu_init(struct cpufreq_policy *policy)
  {
  	struct platform_device *pdev = cpufreq_get_driver_data();

@@ -370,6 +480,10 @@ static int qcom_cpufreq_hw_cpu_init(struct cpufreq_policy *policy)
  			dev_warn(cpu_dev, "failed to enable boost: %d\n", ret);
  	}
+	ret = qcom_cpufreq_hw_lmh_init(policy, index);

You missed unregistering EM here (which is also missing from exit,
which you need to fix first in a separate patch).

Hi!

So how exactly do you do this? I checked other users of the api and I do not
see any free.

Lukasz,

I don't see the cpufreq drivers ever calling dev_pm_opp_of_unregister_em(), and
even if they called, it would translate to em_dev_unregister_perf_domain(),
which has this:

	if (_is_cpu_device(dev))
		return;

I am not sure what's going on here, can you help ?

-- 
viresh