Thread (14 messages) 14 messages, 3 authors, 2021-06-16

Re: [PATCH v1 4/5] clk: tegra: Add stubs needed for compile testing

From: Dmitry Osipenko <digetx@gmail.com>
Date: 2021-06-16 19:35:20
Also in: linux-tegra

16.06.2021 22:08, Daniel Lezcano пишет:
On 07/06/2021 00:28, Dmitry Osipenko wrote:
quoted
Add stubs needed for compile-testing of tegra-cpuidle driver.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 include/linux/clk/tegra.h | 4 ++++
 1 file changed, 4 insertions(+)
diff --git a/include/linux/clk/tegra.h b/include/linux/clk/tegra.h
index d128ad1570aa..9bd06d8a5436 100644
--- a/include/linux/clk/tegra.h
+++ b/include/linux/clk/tegra.h
@@ -42,7 +42,11 @@ struct tegra_cpu_car_ops {
 #endif
 };
 
+#ifdef CONFIG_ARCH_TEGRA
 extern struct tegra_cpu_car_ops *tegra_cpu_car_ops;
+#else
+static struct tegra_cpu_car_ops *tegra_cpu_car_ops __maybe_unused;
+#endif
Why not just have __may_be_unused without the #ifdef ?
The first variant is an external symbol. The tegra_cpu_car_ops* must be
specified somewhere, otherwise linkage will fail. The __maybe_unused
won't help here because symbol must be resolved by linker for the code
where it's used.

The latter variant is a static NULL pointer marked as __maybe_unused.
This allows to include header file universally without producing
compiler warning about the unused static variable during compile-testing.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help