Thread (3 messages) 3 messages, 3 authors, 2021-06-30

Re: [PATCH] powercap: Replace symbolic permissions with octal permissions

From: Joe Perches <joe@perches.com>
Date: 2021-06-30 18:00:19
Also in: lkml

On Wed, 2021-06-30 at 19:41 +0200, Rafael J. Wysocki wrote:
On Thu, Jun 24, 2021 at 10:44 AM Jinchao Wang [off-list ref] wrote:
quoted
Resolve following checkpatch issue,
Replace symbolic permissions with octal permissions
I don't see much value in this replacement and checkpatch complaining
about the existing code base is not something to worry about in
general.
https://lore.kernel.org/lkml/CA+55aFw5v23T-zvDZp-MmD_EYxF8WbafwwB59934FV7g21uMGQ@mail.gmail.com/ (local)

I do agree that in general checkpatch should not really be used as
the sole argument in favor of changing existing code.

So removing the "resolve following checkpatch issue" from the
commit message and replacing it with something like "to improve
readability" would be better.

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help