Thread (7 messages) 7 messages, 2 authors, 2021-06-21

Re: [PATCH v2 1/2] hwmon: (lm90) Prevent integer overflow of temperature calculations

From: Dmitry Osipenko <digetx@gmail.com>
Date: 2021-06-21 12:15:59
Also in: linux-hwmon, linux-tegra, lkml

21.06.2021 15:12, Guenter Roeck пишет:
On Mon, Jun 21, 2021 at 12:14:07AM +0300, Dmitry Osipenko wrote:
quoted
The minimum temperature value that is passed to the driver is unlimited
and value that is close to INT_MIN results in integer overflow of
temperature calculations made by the driver. Limit the value in order
to prevent the overflow. For now the overflow condition is harmless,
but thermal framework won't work properly once we will support the
set_trips() callback because it will pass INT_MIN value to the driver.
AFAICS that should only happen for lm99 because all other values
are bound in the temp_to_xxx functions. Where else do you see an
overflow (or underflow) ?
You're correct that the overflow affects only lm99. But why we should
ignore it?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help