Thread (2 messages) 2 messages, 2 authors, 2021-05-29

Re: [PATCH -next] PM / devfreq: governor: use DEVICE_ATTR_RW macro

From: Chanwoo Choi <hidden>
Date: 2021-05-29 03:15:33
Also in: lkml

On 21. 5. 24. 오전 11:11, YueHaibing wrote:
quoted hunk ↗ jump to hunk
Use DEVICE_ATTR_RW helper instead of plain DEVICE_ATTR,
which makes the code a bit shorter and easier to read.

Signed-off-by: YueHaibing <redacted>
---
  drivers/devfreq/governor_userspace.c | 10 +++++-----
  1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/devfreq/governor_userspace.c b/drivers/devfreq/governor_userspace.c
index 0fd6c4851071..ab9db7adb3ad 100644
--- a/drivers/devfreq/governor_userspace.c
+++ b/drivers/devfreq/governor_userspace.c
@@ -31,8 +31,8 @@ static int devfreq_userspace_func(struct devfreq *df, unsigned long *freq)
  	return 0;
  }
  
-static ssize_t store_freq(struct device *dev, struct device_attribute *attr,
-			  const char *buf, size_t count)
+static ssize_t set_freq_store(struct device *dev, struct device_attribute *attr,
+			      const char *buf, size_t count)
  {
  	struct devfreq *devfreq = to_devfreq(dev);
  	struct userspace_data *data;
@@ -52,8 +52,8 @@ static ssize_t store_freq(struct device *dev, struct device_attribute *attr,
  	return err;
  }
  
-static ssize_t show_freq(struct device *dev, struct device_attribute *attr,
-			 char *buf)
+static ssize_t set_freq_show(struct device *dev,
+			     struct device_attribute *attr, char *buf)
  {
  	struct devfreq *devfreq = to_devfreq(dev);
  	struct userspace_data *data;
@@ -70,7 +70,7 @@ static ssize_t show_freq(struct device *dev, struct device_attribute *attr,
  	return err;
  }
  
-static DEVICE_ATTR(set_freq, 0644, show_freq, store_freq);
+static DEVICE_ATTR_RW(set_freq);
  static struct attribute *dev_entries[] = {
  	&dev_attr_set_freq.attr,
  	NULL,
Applied it. Thanks.

-- 
Best Regards,
Samsung Electronics
Chanwoo Choi
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help