Thread (10 messages) 10 messages, 2 authors, 2021-04-01

Re: [PATCH v5 2/5] powercap/drivers/dtpm: Create a registering system

From: Daniel Lezcano <hidden>
Date: 2021-03-31 20:47:49
Also in: lkml

Hi Greg,

On 31/03/2021 20:06, Greg KH wrote:
On Wed, Mar 31, 2021 at 01:00:45PM +0200, Daniel Lezcano wrote:
quoted
+struct dtpm *dtpm_lookup(const char *name);
+
+int dtpm_add(const char *name, struct dtpm *dtpm);
+
+void dtpm_del(const char *name);
You can not add new kernel apis that have no user.  How do you know if
they actually work or not?  We have no idea as we do not see anyone
using them :(

So no need to add things with no user, feel free to just drop this patch
until you have one.
I've sent a couple of patches [1] on top of the previous series. I'm
finishing to respin it against this new one.

  -- Daniel

[1] https://lkml.org/lkml/2021/3/12/1514


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help