Re: [PATCH v3 3/3] gpio: xilinx: Utilize generic bitmap_get_value and _set_value

From
Syed Nayyar Waris <hidden>
Date
2021-03-26 22:13:48
Also in
linux-arch, linux-arm-kernel, linux-gpio, lkml
Reply to
Andy Shevchenko, 2021-03-26
On Fri, Mar 26, 2021 at 11:32 PM Andy Shevchenko
[off-list ref] wrote:
On Sat, Mar 6, 2021 at 4:08 PM Syed Nayyar Waris [off-list ref] wrote:
quoted
+       bitmap_set_value(old, 64, state[0], 32, 0);
+       bitmap_set_value(old, 64, state[1], 32, 32);
Isn't it effectively bitnap_from_arr32() ?
quoted
+       bitmap_set_value(new, 64, state[0], 32, 0);
+       bitmap_set_value(new, 64, state[1], 32, 32);
Ditto.

--
With Best Regards,
Andy Shevchenko
Hi Andy,

With bitmap_set_value() we are also specifying the offset (or start)
position too. so that the remainder of the array remains unaffected. I
think it would not be feasible to use bitmap_from/to_arr32()  here.

Regards
Syed Nayyar Waris
Thread (16 messages) 16 messages, 6 authors, last reply 2021-04-02
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help