Hello Hans, Chanwoo, Greg,

On Wed, 2021-03-24 at 10:25 +0100, Hans de Goede wrote:

Hi,

On 3/24/21 10:21 AM, Matti Vaittinen wrote:

quoted

Add error print for probe failure when resource managed work-queue
initialization fails.

Signed-off-by: Matti Vaittinen <redacted>
Suggested-by: Chanwoo Choi <cw00.choi@samsung.com>
---
 drivers/extcon/extcon-gpio.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/extcon/extcon-gpio.c b/drivers/extcon/extcon-

gpio.c
index 4105df74f2b0..8ea2cda8f7f3 100644

--- a/drivers/extcon/extcon-gpio.c
+++ b/drivers/extcon/extcon-gpio.c

@@ -114,8 +114,10 @@ static int gpio_extcon_probe(struct

platform_device *pdev)
 		return ret;
 
 	ret = devm_delayed_work_autocancel(dev, &data->work,
gpio_extcon_work);
-	if (ret)
+	if (ret) {
+		dev_err(dev, "Failed to initialize delayed_work");
 		return ret;
+	}

The only ret which we can have here is -ENOMEM and as a rule we don't
log
errors for those, because the kernel memory-management code already
complains
loudly when this happens.

I know. This is why I originally omitted the print. Besides, if the
memory is so low that devres adding fails - then we probably have
plenty of other complaints as well... But as Chanwoo maintains the
driver and wanted to have the print - I do not have objections to that
either. Maybe someone some-day adds another error path to wq
initialization in which case seeing it failed could make sense.

So IMHO this patch should be dropped.

Fine for me - as well as keeping it. I have no strong opinion on this.

Br,
	Matti