Thread (58 messages) 58 messages, 4 authors, 2021-03-18

Re: [PATCH 05/11] PM / devfreq: use more accurate returned new_freq as resume_freq

From: Chanwoo Choi <cw00.choi@samsung.com>
Date: 2021-03-10 02:51:40
Also in: linux-arm-kernel, lkml

On 3/10/21 11:43 AM, Dong Aisheng wrote:
On Tue, Mar 9, 2021 at 11:53 PM Chanwoo Choi [off-list ref] wrote:
quoted
On 21. 3. 9. 오후 9:58, Dong Aisheng wrote:
quoted
Use the more accurate returned new_freq as resume_freq.
It's the same as how devfreq->previous_freq was updated.

Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
---
  drivers/devfreq/devfreq.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
index 6e80bf70e7b3..ce569bd9adfa 100644
--- a/drivers/devfreq/devfreq.c
+++ b/drivers/devfreq/devfreq.c
@@ -390,7 +390,7 @@ static int devfreq_set_target(struct devfreq *devfreq, unsigned long new_freq,
      devfreq->previous_freq = new_freq;

      if (devfreq->suspend_freq)
-             devfreq->resume_freq = cur_freq;
+             devfreq->resume_freq = new_freq;

      return err;
  }
This patch fixes the previous patch[1]. So that you need to
add 'Fixes' tag as following:

Fixes: 83f8ca45afbf0 ("PM / devfreq: add support for suspend/resume of a
devfreq device")
Will add Fixes tag in next version.

On next version, recommend to place this patch at the first.
quoted
commit 83f8ca45afbf041e312909f442128b99657d90b7
Refs: v4.20-rc6-2-g83f8ca45afbf
Author:     Lukasz Luba [off-list ref]
AuthorDate: Wed Dec 5 12:05:53 2018 +0100
Commit:     MyungJoo Ham [off-list ref]
CommitDate: Tue Dec 11 11:09:47 2018 +0900

     PM / devfreq: add support for suspend/resume of a devfreq device


--
Best Regards,
Samsung Electronics
Chanwoo Choi

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help