Re: [thermal: thermal/next] iio: adc: qcom-vadc-common: use fixp_linear_interpolate
From: kernel test robot <hidden>
Date: 2021-02-18 22:05:01
Also in:
oe-kbuild-all
Hi thermal-bot, Thank you for the patch! Yet something to improve: [auto build test ERROR on thermal/next] url: https://github.com/0day-ci/linux/commits/thermal-bot-for-Dmitry-Baryshkov/iio-adc-qcom-vadc-common-use-fixp_linear_interpolate/20210219-045140 base: https://git.kernel.org/pub/scm/linux/kernel/git/rzhang/linux.git next config: xtensa-allyesconfig (attached as .config) compiler: xtensa-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/2ba8f2d19b304bc7ba06b875527258b02bed2053 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review thermal-bot-for-Dmitry-Baryshkov/iio-adc-qcom-vadc-common-use-fixp_linear_interpolate/20210219-045140 git checkout 2ba8f2d19b304bc7ba06b875527258b02bed2053 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=xtensa If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <redacted> All errors (new ones prefixed by >>): drivers/iio/adc/qcom-vadc-common.c: In function 'qcom_vadc_map_voltage_temp':
quoted
drivers/iio/adc/qcom-vadc-common.c:158:13: error: implicit declaration of function 'fixp_linear_interpolate' [-Werror=implicit-function-declaration]
158 | *output = fixp_linear_interpolate(pts[i - 1].x, pts[i - 1].y,
| ^~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/fixp_linear_interpolate +158 drivers/iio/adc/qcom-vadc-common.c
121
122 static int qcom_vadc_map_voltage_temp(const struct vadc_map_pt *pts,
123 u32 tablesize, s32 input, int *output)
124 {
125 bool descending = 1;
126 u32 i = 0;
127
128 if (!pts)
129 return -EINVAL;
130
131 /* Check if table is descending or ascending */
132 if (tablesize > 1) {
133 if (pts[0].x < pts[1].x)
134 descending = 0;
135 }
136
137 while (i < tablesize) {
138 if ((descending) && (pts[i].x < input)) {
139 /* table entry is less than measured*/
140 /* value and table is descending, stop */
141 break;
142 } else if ((!descending) &&
143 (pts[i].x > input)) {
144 /* table entry is greater than measured*/
145 /*value and table is ascending, stop */
146 break;
147 }
148 i++;
149 }
150
151 if (i == 0) {
152 *output = pts[0].y;
153 } else if (i == tablesize) {
154 *output = pts[tablesize - 1].y;
155 } else {
156 /* result is between search_index and search_index-1 */
157 /* interpolate linearly */
> 158 *output = fixp_linear_interpolate(pts[i - 1].x, pts[i - 1].y,
159 pts[i].x, pts[i].y,
160 input);
161 }
162
163 return 0;
164 }
165
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Attachments
- .config.gz [application/gzip] 60416 bytes